Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip src and doc packaging when publishing locally #1665

Merged
merged 1 commit into from
Sep 10, 2022

Conversation

bjaglin
Copy link
Collaborator

@bjaglin bjaglin commented Sep 10, 2022

Follows e099cc4#r846677704. This brings back time savings of ~1-2 minutes for test on cold invocations, but also on warm ones, as it seems that scaladoc is not incremental/cached.

This should also benefit #1650, where we observe exceptions generating docs with scala 3.2.0 on windows:

[error] Caused by: java.nio.file.InvalidPathException: Illegal char <:> at index 30: scalafix/util/TreeExtractors$$:&&:$.html
[error] 	at sun.nio.fs.WindowsPathParser.normalize(WindowsPathParser.java:182)
[error] 	at sun.nio.fs.WindowsPathParser.parse(WindowsPathParser.java:153)
[error] 	at sun.nio.fs.WindowsPathParser.parse(WindowsPathParser.java:77)
[error] 	at sun.nio.fs.WindowsPath.parse(WindowsPath.java:94)
[error] 	at sun.nio.fs.WindowsFileSystem.getPath(WindowsFileSystem.java:255)
[error] 	at sun.nio.fs.AbstractPath.resolve(AbstractPath.java:53)
[error] 	at dotty.tools.scaladoc.renderers.Writer.dest(Writer.scala:17)
[error] 	at dotty.tools.scaladoc.renderers.Writer.write(Writer.scala:23)
[error] 	at dotty.tools.scaladoc.renderers.Writer.write$(Writer.scala:13)
[error] 	at dotty.tools.scaladoc.renderers.Renderer.write(Renderer.scala:27)
[error] 	at dotty.tools.scaladoc.renderers.Renderer.renderPage(Renderer.scala:177)
[error] 	at dotty.tools.scaladoc.renderers.Renderer.renderPage$$anonfun$1(Renderer.scala:177)

@bjaglin bjaglin marked this pull request as ready for review September 10, 2022 15:51
@bjaglin bjaglin merged commit 5d55ab4 into scalacenter:main Sep 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant