-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Post 0.10.0 #1568
Post 0.10.0 #1568
Conversation
6cd8baa
to
f7e309c
Compare
It looks like sbt-version-policy does not handle the |
It seems to be the same problem as coursier/coursier#2370. However, forcing an ivy versionPolicyInternal.versionPolicyDependencyResolution := {
// Try to fallback to ivy to avoid https://github.com/coursier/coursier/issues/2370
IvyDependencyResolution(ivySbt.value.configuration)
}, sbt/sbt#5568 might be relevant too. |
Both ivy and coursier seem to get runtime dependencies in the compile report ThisBuild / useCoursier := true
test := {
val depRes = dependencyResolution.value
val update0 = depRes.update(
depRes.wrapDependencyInModule("ch.epfl.scala" % "scalafix-core_2.12" % "0.10.0"),
updateConfiguration.value,
(update / unresolvedWarningConfiguration).value,
sLog.value
)
println(update0.right.get.configuration(Compile).get)
}
|
Worked around it by excluding pprint from the check ... |
versionPolicyIgnoredInternalDependencyVersions := | ||
Some("^\\d+\\.\\d+\\.\\d+\\+\\d+".r), | ||
versionScheme := Some("early-semver"), | ||
versionPolicyIntention := Compatibility.None // TODO: harden after 0.10.0 | ||
versionPolicyIntention := Compatibility.BinaryCompatible |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since we are still in 0.x.y, we'll need to bump a minor anyway for the next release (and not a "semantic" patch), so there is not interest in checking BinaryAndSourceCompatible
We'll probably have to tweak https://github.com/scalacenter/sbt-version-policy/blob/0fdfd36d6547af1334ab5bdba3f985f1e6ca1267/README.md#dependency-compatibility-adjustments down the line as I assume a few dependency are SemVer (but tagged as PVP by lack of explicit annotation) and would cause false positives.