Update named-literal-rules #1529
Conversation
docs/developers/tutorial.md
Outdated
| @@ -86,7 +85,7 @@ output/src | |||
| ``` | |||
|
|
|||
| Checkout the commit | |||
| [55f9196163ab0a](https://github.com/olafurpg/named-literal-arguments/commit/55f9196163ab0a5dde22364ab1f7880bf4a5dc54), | |||
| [55f9196163ab0a](https://github.com/scalacenter/scalafix-named-literal-arguments/commit/55f9196163ab0a5dde22364ab1f7880bf4a5dc54), | |||
There was a problem hiding this comment.
I am wondering if we shouldn't rewrite the history to match the new APIs (instead of fixing it in a last commit together with the bump), WDYT?
There was a problem hiding this comment.
I have never done that.. why not! It's supposed to compile even when using old hash ! If we rewrite history, we need to rewrite more than one commit.. I don't know how many, but I guess it's doable. Do you think it's worth it ?
There was a problem hiding this comment.
Now that you have rewritten history, shouldn't this be scalacenter/scalafix-named-literal-arguments@12dce51?
All branches containing scalacenter/scalafix-named-literal-arguments@55f9196 should probably be updated (particularly the step-* ?)
There was a problem hiding this comment.
It pushed to my clone repo instead of origin/mlachkar-patch-1.
I will update the step branches on scalafix-named-literals.
There was a problem hiding this comment.
I have updated the steps on the project
docs/developers/tutorial.md
Outdated
| @@ -627,7 +626,7 @@ Another way to run custom rules from source is to use the `github:org/repo` | |||
| scheme. | |||
|
|
|||
| ``` | |||
| scalafix --rules=github:olafurpg/named-literal-arguments | |||
| scalafix --rules=github:scalacenter/scalafix-named-literal-arguments | |||
There was a problem hiding this comment.
isn't the removal of scalafix breaking that https://scalacenter.github.io/scalafix/docs/developers/tutorial.html#using-github ?
There was a problem hiding this comment.
you're right. It's not working at all.
it needs the directory scalafix + it's not the name of the repo, but the name of the rule: https://raw.githubusercontent.com/scalacenter/named-literal-arguments/master/rules/src/main/scala/fix/NamedLiteralArguments.scala
Do I rollback and put everything inside the directory scalafix ? It's annoying to have this directory sometimes, since ideas don't recognize it's scala code.
|
I have rewrite the history and re-create the hierarchy of folders! |
mlachkar
force-pushed
the
mlachkar-patch-1
branch
from
1b4486c
to
2f576a9
Compare
Co-authored-by: Brice Jaglin <[email protected]>
fixes #1518