-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip exported methods and BoxeRuntimes #594
Skip exported methods and BoxeRuntimes #594
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about the exported methods. Are they already filtered out? What about adding a test? Should we work on them in a different PR?
modules/core/src/main/scala/ch/epfl/scala/debugadapter/internal/stacktrace/ScalaUnpickler.scala
Outdated
Show resolved
Hide resolved
They are already filtered out in the first commit (with a test), did I miss some exported methods? |
My bad. I looked at the last commit only. |
...s/core/src/main/scala/ch/epfl/scala/debugadapter/internal/stacktrace/RuntimeStepFilter.scala
Outdated
Show resolved
Hide resolved
There is a test that fails because it was stepping into
|
b815745
to
4e13d9c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Fixes #560 #540