Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip exported methods and BoxeRuntimes #594

Merged
merged 5 commits into from
Sep 22, 2023

Conversation

iusildra
Copy link
Contributor

@iusildra iusildra commented Sep 15, 2023

Fixes #560 #540

@iusildra iusildra linked an issue Sep 15, 2023 that may be closed by this pull request
@iusildra iusildra marked this pull request as ready for review September 15, 2023 14:27
Copy link
Member

@adpi2 adpi2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about the exported methods. Are they already filtered out? What about adding a test? Should we work on them in a different PR?

@iusildra
Copy link
Contributor Author

They are already filtered out in the first commit (with a test), did I miss some exported methods?

@adpi2
Copy link
Member

adpi2 commented Sep 19, 2023

They are already filtered out in the first commit (with a test), did I miss some exported methods?

My bad. I looked at the last commit only.

@adpi2
Copy link
Member

adpi2 commented Sep 20, 2023

There is a test that fails because it was stepping into BoxesRunTime:

[error] ==> X ch.epfl.scala.debugadapter.Scala212StepFilterTests.should match all kinds of types  3.13s munit.ComparisonFailException: /home/runner/work/scala-debug-adapter/scala-debug-adapter/modules/tests/src/test/scala/ch/epfl/scala/debugadapter/StepFilterTests.scala:775
[error] 774:      Breakpoint(32),
[error] 775:      StepIn.method("BoxesRunTime.boxToInteger(int): Integer"),
[error] 776:      StepOut.line(32),
[error] values are not the same
[error] => Obtained
[error] Main$.m(Object): Object
[error] => Diff (- obtained, + expected)
[error] -Main$.m(Object): Object
[error] +BoxesRunTime.boxToInteger(int): Integer

@iusildra iusildra force-pushed the skip-exported-and-boxesruntime branch from b815745 to 4e13d9c Compare September 22, 2023 09:31
Copy link
Member

@adpi2 adpi2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@adpi2 adpi2 merged commit e535f77 into scalacenter:main Sep 22, 2023
9 checks passed
adpi2 added a commit that referenced this pull request Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Skip the exported method in Scala 3 Should skip scala.runtime.BoxesRunTime
2 participants