Scala 2.13.6 & -Xsource:3 support #221
Conversation
bjaglin
changed the title
| */ | ||
| package fix | ||
|
|
||
| open class Source3 |
There was a problem hiding this comment.
addresses scalacenter/scalafix#1409 (comment)
| settings = Seq( | ||
| scalacOptions += "-P:semanticdb:synthetics:on" |
There was a problem hiding this comment.
force-pushed: this was not used!
| settings = Seq( | ||
| scalacOptions += "-P:semanticdb:synthetics:on" | ||
| scalacOptions += "-Xsource:3" |
There was a problem hiding this comment.
I think this shows how nice sbt-projectmatrix can be!
There was a problem hiding this comment.
I agree. The only thing I am worried about, is if we are the only project that use it. It introduces some new syntax to understand/learn, especially that sbt is usually not something that people master correctly.
There was a problem hiding this comment.
The rule authors shouldn't have to touch anything in projects bootstrapped by scalacenter/scalafix.g8#19 unless they need to disable scala3 testing (which I enabled on purpose). Maybe that's something to discuss on the PR?
There was a problem hiding this comment.
or maybe they want to write only for scala 3. I think it should be easy to remove axes that the authors don't want?
There was a problem hiding this comment.
let's discuss this on the PR.
|
CI is broken at the moment https://www.githubstatus.com/incidents/m16jzl31gnqt |
| open class Source3 | ||
|
|
||
| object Source3 { | ||
| implicit class XtensionVal(val str: String) extends AnyVal { |
There was a problem hiding this comment.
just amended the last commit yo move this inside an object to avoid
[info] [error] /tmp/sbt_5a68d1e4/cross-build/scala213/src/main/scala/Source3.scala:3:16: XtensionVal is already defined as (compiler-generated) method XtensionVal
scalacenter/scalafix#1408
scalacenter/scalafix#1409