make it possible to and do build against a scalafix SNAPSHOT #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjaglin
changed the title
bjaglin
force-pushed
the
snapshot
branch
2 times, most recently
from
a2cf9e2
to
2150e2f
Compare
bjaglin
commented
May 12, 2021
Comment on lines
+11
to
+13
| val suite = new AbstractSemanticRuleSuite with FunSuiteLike { | ||
| override val props = TestkitProperties.loadFromResources() | ||
| override val isSaveExpect = true |
There was a problem hiding this comment.
Non-trivial usage of SemanticRuleSuite that https://github.com/scalacenter/scalafix/pull/1395/files won't cover. See also scalacenter/scalafix#1147.
bjaglin
force-pushed
the
snapshot
branch
2 times, most recently
from
8cdca64
to
cdc31bf
Compare
- clients that have sonatype public in the metabuild and do not override scalafixResolvers can resolve a SNAPSHOT scalafix as sonatype snapshots is added by default - fix failing tests by sticking to the plugin default - fix failing scripted by removing unnecessary scalafixResolvers overrides or adding the sonatype snapshots resolver when scalafix is resolved directly - fix breaking changes in scalafix
bjaglin
commented
May 12, 2021
| @@ -27,6 +27,11 @@ object ScalafixTestkitPlugin extends AutoPlugin { | |||
| } | |||
| import autoImport._ | |||
|
|
|||
| override def buildSettings: Seq[Def.Setting[_]] = | |||
| List( | |||
| resolvers += Resolver.sonatypeRepo("snapshots") | |||
There was a problem hiding this comment.
ScalafixTestkitPlugin clients of a SNAPSHOT sbt-scalafix must resolve from sonatype snapshots both scalafix-testkit for the test project (where that sbt plugin is enabled) AND scalafix-core for the actual rules project, thus the need for impacting the entire build and not just the project settings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows #210
It's useful to build and run all scripted tests against a scalafix SNAPSHOT to avoid getting (late) surprises during the 2-step (scalafix/sbt-scalafix) release phase.
Most of the users running SNAPSHOT versions of sbt-scalafix should be able to use one that depends on a SNAPSHOT scalafix since they must already have sonatype snapshots in the metabuild and the default
scalafixResolverswill re-resolve scalafix through sonatype snapshots via the embedded coursier.