caching: remove optimization bringing false positive cache hits #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjaglin
commented
Jul 10, 2020
| @@ -216,6 +217,7 @@ $ exec chmod 000 src/main/scala/Valid.scala | |||
| > scalafix --check ProcedureSyntax | |||
| -> test:scalafix --check ProcedureSyntax | |||
| > test:scalafix ProcedureSyntax | |||
| > test:scalafix ProcedureSyntax | |||
There was a problem hiding this comment.
a second run is needed for the cache to converge since there is a rewrite involved
bjaglin
commented
Jul 10, 2020
| > set scalafixConfig := None | ||
| $ mkdir src/test/scala | ||
| $ copy-file files/ProcedureSyntax.scala src/test/scala/ToPatch.scala | ||
| $ copy-file files/Valid.scala src/test/scala/Valid.scala | ||
| # avoid rounding in mtime that could cause false negatives in `newer` | ||
| $ sleep 1000 | ||
| > test:scalafix ProcedureSyntax | ||
| > test:scalafix ProcedureSyntax DisableSyntax |
There was a problem hiding this comment.
adding a second rule for exhibiting the scenario, even though behavior is the same no matter how many rules we have (but it might change one day)
If a file is patched during a scalafix run, it's not safe to assume that all rules observed the updated content of that file and thus can be skipped next time. It is if we have only one rule (which we could check) or if the patch is applied after the first rule (which we can't tell). For correctness, stamping should happen before rule execution.
bjaglin
commented
Jul 10, 2020
| $ newer src/test/scala/ToPatch.scala src/test/scala/Valid.scala | ||
| $ exec chmod 000 src/test/scala/ToPatch.scala | ||
| $ exec chmod 000 src/test/scala/Valid.scala |
There was a problem hiding this comment.
irrelevant to the assertion, it's just useful to assert above via newer that ToPatch was updated
olafurpg
approved these changes
Jul 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
scalacenter/scalafix#1164 (comment)
If a file is patched during a scalafix run, it's not safe to assume that all rules observed the updated content of that file and thus can
be skipped next time. It is if we have only one rule (which we could check) or if the patch is applied after the first rule (which we can't tell). For correctness, stamping should happen before rule execution.