Compilation tweaks #114
Merged
Compilation tweaks #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjaglin
force-pushed
the
compilation-tweaks
branch
from
f68c29d
to
a0be19c
Compare
bjaglin
commented
May 28, 2020
| @@ -11,7 +11,7 @@ class LoggingOutputStream( | |||
| separator: String | |||
| ) extends OutputStream { | |||
|
|
|||
| private val baos = new ByteArrayOutputStream { | |||
| class LinesExtractorOutputStream extends ByteArrayOutputStream { | |||
There was a problem hiding this comment.
avoid -language:reflectiveCalls
| @@ -30,7 +30,7 @@ class JGitCompletion(cwd: Path) { | |||
| } | |||
|
|
|||
| val branchesAndTags: List[String] = | |||
| refList.map { case (a, _) => Repository.shortenRefName(a) }.toList | |||
| refList.map { ref => Repository.shortenRefName(ref.getName) }.toList | |||
There was a problem hiding this comment.
bjaglin
commented
May 28, 2020
| @@ -113,7 +113,7 @@ class SbtCompletionsSuite extends AnyFunSuite { | |||
| |""".stripMargin.trim.replaceAll("\r\n", "\n") | |||
| if (obtained != expected) { | |||
| println("\"\"\"|") | |||
| obtained.lines.foreach { line => | |||
| obtained.linesIterator.foreach { line => | |||
There was a problem hiding this comment.
mlachkar
approved these changes
Jun 3, 2020
olafurpg
approved these changes
Jun 3, 2020
|
Thanks both for the review!
Do you find it too strict?
Indeed, but I guess that won't help until sbt 2.x (?) for sbt plugins. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.