Use scala-debug-adapter as a dependency #1454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adpi2
force-pushed
the
debug-server
branch
5 times, most recently
from
34721c9 to
02d6a98
Compare
|
The scala-debug-adapter v1.0.0 is released. So this PR is ready to be reviewed. |
adpi2
changed the title
tgodzik
approved these changes
May 21, 2021
| initialState: State, | ||
| ioScheduler: Scheduler | ||
| ) extends BloopDebuggeeRunner(initialState, ioScheduler) { | ||
| override def name: String = { |
There was a problem hiding this comment.
What is the name needed for?
There was a problem hiding this comment.
The name is used by the DebugServer for logging when there is a problem:
- a timeout waiting for the
DebuggeeRunnerto start - a timeout waiting for the
Terminatedevent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As orginally discussed here, the plan is to extract the Bloop
DebugServerin a separate repostiory, scala-debug-adapter, so that we can reuse it for implementing thedebugSession/startendpoint in other build tools. We'll start with sbt, but it could also be implemented in Mill.In this PR I just want to test back that Bloop integrates well with the
scala-debug-adapterlibrary. It is not meant to be merged until thescala-debug-adapteris released.