Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Google Analytics #8201

Merged
merged 4 commits into from
Nov 19, 2024
Merged

Remove Google Analytics #8201

merged 4 commits into from
Nov 19, 2024

Conversation

fm3
Copy link
Member

@fm3 fm3 commented Nov 16, 2024

Steps to test:

  • CI should be enough

Issues:


Summary by CodeRabbit

Release Notes

  • New Features

    • Enhanced asynchronous handling of image file reading for improved efficiency.
    • Improved handling of remote URIs from Neuroglancer by ignoring format prefixes.
  • Bug Fixes

    • Resolved performance bottleneck during the deletion of multiple trees.
    • Fixed issue with importing NML files that lacked trees.
    • Corrected critical bug that deleted the entire active tree when attempting to delete a non-existing node via the API.
    • Improved clarity of error messages for starting jobs on datasets from other organizations.
    • Removed bounding box size restriction for inferral jobs for super users.
  • Chores

    • Removed integration of Google Analytics across the application, including tracking functionality in various components.

Copy link
Contributor

coderabbitai bot commented Nov 16, 2024

Walkthrough

The pull request involves the removal of Google Analytics from the WEBKNOSSOS project, including the deletion of related tracking functions and configuration options. Asynchronous file reading has been implemented for improved efficiency, and several performance fixes have been made, including resolving issues with tree deletions and NML file imports. The migration guide has been updated to reflect these changes, particularly regarding the removal of the Google Analytics tracking ID.

Changes

File Path Change Summary
CHANGELOG.unreleased.md Updated to reflect changes including removal of Google Analytics and performance fixes.
MIGRATIONS.unreleased.md Added note about removal of googleAnalytics.trackingId.
app/utils/WkConf.scala Removed GoogleAnalytics object and updated children list.
app/views/main.scala.html Removed Google Analytics tracking functionality from HTML.
conf/application.conf Removed Google Analytics section and updated various settings.
frontend/javascripts/admin/dataset/dataset_upload_view.tsx Removed trackAction from finishDatasetUpload, enhanced error handling, and updated validation rules.
frontend/javascripts/dashboard/advanced_dataset/dataset_table.tsx Removed trackAction from editTagFromDataset, refined context menu logic.
frontend/javascripts/dashboard/dataset/dataset_settings_view.tsx Removed trackAction from submit, enhanced user feedback and validation logic.
frontend/javascripts/dashboard/explorative_annotations_view.tsx Removed trackAction from setLockedState and editTagFromAnnotation, updated UI rendering logic.
frontend/javascripts/main.tsx Removed googleAnalyticsLogClicks function from click event listener.
frontend/javascripts/navbar.tsx Renamed getAndTrackVersion to getVersion, removed tracking functionality.
frontend/javascripts/oxalis/model/helpers/analytics.ts Deleted file containing Google Analytics tracking functions.
frontend/javascripts/oxalis/model/sagas/settings_saga.ts Removed trackUserSettingsAsync, refined error handling in pushDatasetSettingsAsync.
frontend/javascripts/oxalis/view/action_bar_view.tsx Removed trackAction from createAnnotation, updated additional coordinates handling.
frontend/javascripts/oxalis/view/nml_upload_zone_container.tsx Removed trackAction from onDrop, no other changes.
frontend/javascripts/router.tsx Removed Google Analytics tracking for page views and trackAction from routing logic.

Assessment against linked issues

Objective Addressed Explanation
Remove Google Analytics (7388)

Possibly related PRs

Suggested labels

bug

"In the garden where data used to play,
Google Analytics has hopped away.
With trees now deleted and files read fast,
Our code is cleaner, improvements amassed.
No more tracking, just joy in the air,
A brighter path for all who dare!" 🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 664a323 and c1416fb.

📒 Files selected for processing (2)
  • CHANGELOG.unreleased.md (1 hunks)
  • frontend/javascripts/dashboard/explorative_annotations_view.tsx (0 hunks)
💤 Files with no reviewable changes (1)
  • frontend/javascripts/dashboard/explorative_annotations_view.tsx
🚧 Files skipped from review as they are similar to previous changes (1)
  • CHANGELOG.unreleased.md

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@fm3 fm3 requested a review from daniel-wer November 16, 2024 10:04
Copy link
Member

@daniel-wer daniel-wer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you for taking the time!

Once this is deployed, we can clean up some of our CSP directives.

@fm3 fm3 enabled auto-merge (squash) November 19, 2024 12:10
@fm3 fm3 merged commit 42f1c52 into master Nov 19, 2024
3 checks passed
@fm3 fm3 deleted the remove-google-analytics branch November 19, 2024 12:14
@coderabbitai coderabbitai bot mentioned this pull request Dec 5, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Google Analytics
2 participants