Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow admins to view and cancel other users jobs #8112

Merged
merged 3 commits into from
Oct 7, 2024

Conversation

frcroth
Copy link
Member

@frcroth frcroth commented Oct 7, 2024

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • Create a job as a non admin user (Or create a job as an admin user and edit the owner in the DB)
  • Be able to see it and cancel it
  • Note that the owner is now displayed in the job list

Notes

  • No changes were required to make canceling possible
  • The SQL change is copied from the readAccessQ
  • The frontend change (new column) is copied from the Project List

Issues:


(Please delete unneeded items, merge only when none are left open)

  • Updated changelog
  • Updated documentation if applicable The jobs page was already old before (e.g. screenshot shows old logo, different UI), but the text is unchanged
  • Removed dev-only changes like prints and application.conf edits
  • Considered common edge cases

@frcroth frcroth changed the title Allow admins to cancel other users jobs Allow admins to cancel non-owned jobs Oct 7, 2024
@frcroth frcroth self-assigned this Oct 7, 2024
@frcroth frcroth changed the title Allow admins to cancel non-owned jobs Allow admins to view and cancel other users jobs Oct 7, 2024
Copy link
Member

@fm3 fm3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and works for me :)

Let’s see how the performance will look in production (the lists get longer now, as all users’ jobs will be shown). It may become necessary to transition the list route to a complex query eventually.

@frcroth frcroth removed the request for review from MichaelBuessemeyer October 7, 2024 11:42
@frcroth frcroth merged commit 2cd6647 into master Oct 7, 2024
2 checks passed
@frcroth frcroth deleted the admin-can-cancel-jobs branch October 7, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

List all jobs of orga to admin
3 participants