Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix moving non zipped uploaded dataset to target folder #8103

Merged
merged 4 commits into from
Sep 25, 2024

Conversation

MichaelBuessemeyer
Copy link
Contributor

@MichaelBuessemeyer MichaelBuessemeyer commented Sep 25, 2024

Fix bug for uploading datasets in case a baseFolder is configured for the datastore. The error is caused by path.subpath always returning a relative path even in case the path is absolute. This is intended behaviour by the docs 🙈

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • Test locally. Configure a in application.conf:
    datastore {
    baseFolder = `<absolute_path_to_binary_folder>`
    
  • run yarn enable-jobs
  • Test uploading a zip file, a single file (e.g. tiff) and multiple files e.g. multiple jpegs.
  • Every try should succeed

Issues:


(Please delete unneeded items, merge only when none are left open)

  • Updated changelog
  • Needs datastore update after deployment

@normanrz normanrz merged commit ce8ffb3 into master Sep 25, 2024
2 checks passed
@normanrz normanrz deleted the fix-moving-non-zipped-uploaded-dataset branch September 25, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants