Disable proofreading actions for mapped meshes #8091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelBuessemeyer
requested changes
Sep 24, 2024
There was a problem hiding this comment.
Nice, testing went well 🎉
I only found a very small improvement of your changes. But while looking at the code I found some duplications. It would be very nice if you could refactor some of the duplication away. For more details please see my comments below.
Besides that, this pr should be ready to be 
MichaelBuessemeyer
approved these changes
Sep 25, 2024
Comment on lines
+418
to
+428
| const getTooltip = (actionVerb: "merge" | "split", actionNeedsActiveSegment: boolean) => { | ||
| return !isProofreadingActive | ||
| ? `Cannot ${actionVerb} because the proofreading tool is not active.` | ||
| : maybeUnmappedSegmentId == null | ||
| ? "The mesh wasn't loaded in proofreading mode. Please reload the mesh." | ||
| : meshFileMappingName != null | ||
| ? "This mesh was created for a mapping. Please use a meshfile that is based on unmapped oversegmentation data." | ||
| : actionNeedsActiveSegment && activeSegmentMissing | ||
| ? "Select a segment first." | ||
| : null; | ||
| }; |
Comment on lines
+430
to
+434
| const shouldAgglomerateSkeletonActionsBeDisabled = | ||
| !isProofreadingActive || | ||
| activeSegmentMissing || | ||
| maybeUnmappedSegmentId == null || | ||
| meshFileMappingName != null; |
dieknolle3333
deleted the
disable-proofreading-actions-for-mapping-meshfiles
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
URL of deployed dev instance (used for testing):
Steps to test:
(see this comment too: #7868 (comment))
Issues:
(Please delete unneeded items, merge only when none are left open)