Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Bounding Box Selection #8054

Merged
merged 7 commits into from
Sep 9, 2024
Merged

Improve Bounding Box Selection #8054

merged 7 commits into from
Sep 9, 2024

Conversation

dieknolle3333
Copy link
Contributor

@dieknolle3333 dieknolle3333 commented Sep 3, 2024

URL of deployed dev instance (used for testing):

Steps to test:

  • Open an annotation with some bounding boxes
  • Within a view port (except 3D), right-click on a bounding box edge. In the context menu, a new entry should appear, that lets you focus the BB in the BB tab (if open). Make sure this work. If the list entry wasnt visible due to scrolling, clicking this new context menu action should focus it
  • Hovering above the edge of a bounding box should highlight it
  • Within the move tool, left clicking the edge of a bounding box should focus it in the bounding box tab and make it the active bounding box
  • This behaviour (on click) should not interfere with other tools. Although the highlighting of the edges is still active in other tools, similar to the highlighting of segments.

TODOs:

  • Allow to select a bbox in move tool via ctrl + click (just like in bbox tool)
    • what about event.shiftKey || !useLegacyBindings
  • Allow to select a bbox in 3d viewport is a separate issue
  • In any tool, the bbox borders are highlighted upon hovering. Why? Is this good? -> "If a tool does not define a specific mouse binding, the bindings of the MoveTool are used as a fallback."

Issues:


(Please delete unneeded items, merge only when none are left open)

@dieknolle3333 dieknolle3333 self-assigned this Sep 3, 2024
@dieknolle3333 dieknolle3333 marked this pull request as ready for review September 5, 2024 09:42
Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, works great 👍

@philippotto philippotto enabled auto-merge (squash) September 9, 2024 09:34
@philippotto philippotto merged commit 2b2469c into master Sep 9, 2024
2 checks passed
@philippotto philippotto deleted the improve-bbox-selection branch September 9, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve BBox Selection Mechanism
2 participants