Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make "Go to center of bounding box" available at one click #8049

Merged
merged 11 commits into from
Sep 9, 2024

Conversation

dieknolle3333
Copy link
Contributor

@dieknolle3333 dieknolle3333 commented Sep 2, 2024

URL of deployed dev instance (used for testing):

Steps to test:

  • Open an annotation with some bounding boxes
  • Click anywhere in a bounding box entry. This should center the bounding box within the view ports
  • Editing the color, the name, the coordinates, clicking the context menu or any of its entries or switching the visibility shouldnt center the bbox
  • the rest of the UI should be working as before

TODOs:

  • editing the coordinates or the color shouldnt focus bbox

Issues:


(Please delete unneeded items, merge only when none are left open)

@dieknolle3333 dieknolle3333 self-assigned this Sep 2, 2024
@dieknolle3333 dieknolle3333 marked this pull request as ready for review September 4, 2024 07:33
@philippotto
Copy link
Member

cool!! ideally, the cursor should also indicate that the entire row is clickable. this should work with css (cursor: pointer).

@philippotto
Copy link
Member

getting there 😄 unfortunately, the hover target area is not identical to the click target area. clicking close to the edge does not work (the cursor also rightfully indicates that):

image

maybe a margin or padding needs to be adapted or the click handler (+ css class) needs to be one level further up in the hierarchy?

@dieknolle3333
Copy link
Contributor Author

Very good point! I think I fixed it :)

Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome! feels really slick :)

@philippotto philippotto merged commit 8b7fa1c into master Sep 9, 2024
2 checks passed
@philippotto philippotto deleted the center-bb-single-click branch September 9, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Go to center of BBox should be available with a single click
2 participants