detect neuroglancer precomputed and n5 datasets as needsConversion=false #8008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dieknolle3333
pushed a commit
that referenced
this pull request
Sep 2, 2024
…lse (#8008) * detect neuroglancer precomputed and n5 datasets as needsConversion=false * changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The backend supports auto-writing a datasource-properties.json for neuroglancer-precomputed and n5 datasets as of #7578 . However, the frontend apparently did not know that and starts a conversion job instead.
Also, I’m using the basenames for the file checks now, because in the zip case, a root directory may be prepended to the filenames. This may in theory cause false positives, but I guess those datasets will be broken and non-convertable anyway
I’d suggest not to adapt the docs/message, as we want to encourage using zarr (?) Or I guess the messages will be adapted anyway in #7996
Steps to test: