Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register all segments in a bounding box #7979

Merged
merged 23 commits into from
Aug 14, 2024

Conversation

dieknolle3333
Copy link
Contributor

@dieknolle3333 dieknolle3333 commented Aug 6, 2024

URL of deployed dev instance (used for testing):

Steps to test:

  • Go to bounding box tab
  • inspect new overflow menu
  • make sure everything works as before
  • try out new action: "register all segments for bounding box"
  • test segment and data limits

TODOs

  • add context menu
  • add new entry with functionality
  • include limits on segments and data
  • add constant
  • add padding to BB entries
  • fix spacing
  • add registered segments to group
  • test that all the old disabling of context menu entries is still working
  • fix segment 0 bug
  • disable if allowupdate is false

Issues:


(Please delete unneeded items, merge only when none are left open)

@dieknolle3333 dieknolle3333 self-assigned this Aug 6, 2024
@dieknolle3333 dieknolle3333 marked this pull request as ready for review August 8, 2024 14:56
Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

already quite cool :)

Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getting there :)

frontend/javascripts/oxalis/api/api_latest.ts Outdated Show resolved Hide resolved
frontend/javascripts/oxalis/api/api_latest.ts Outdated Show resolved Hide resolved
frontend/javascripts/oxalis/api/api_latest.ts Outdated Show resolved Hide resolved
frontend/javascripts/oxalis/api/api_latest.ts Outdated Show resolved Hide resolved
frontend/javascripts/oxalis/constants.ts Outdated Show resolved Hide resolved
frontend/javascripts/oxalis/api/api_latest.ts Outdated Show resolved Hide resolved
frontend/javascripts/oxalis/api/api_latest.ts Outdated Show resolved Hide resolved
@dieknolle3333
Copy link
Contributor Author

dieknolle3333 commented Aug 12, 2024

TODO: if I choose a bb where there are no segments, this happens
image
edit: hopefully done

Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dieknolle3333 dieknolle3333 merged commit 06ff8ae into master Aug 14, 2024
2 checks passed
@dieknolle3333 dieknolle3333 deleted the register-all-segments-in-bb branch August 14, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Segments for all ids in a bounding box
2 participants