-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Virtualize Bounding Box List #7974
Conversation
The code looks good and the UI too 👍 however, there is one thing: due to the "add bbox button", there is a native scrollbar (in addition to the virtualized but invisible one): I think, you need to adapt the layout so that the div, that contains the table and the plus-button, is exactly as tall as there is available space. I see two options for that: since the plus-button is part of the table, I'm not sure why this is happening in the first place. maybe the culprit is somewhere else. can you reproduce this? |
Oh yes, I can reproduce this. I didnt notice that this was an additional scroll bar. But yeah, its weird that this happens! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works well 🎉
URL of deployed dev instance (used for testing):
Steps to test:
Issues:
(Please delete unneeded items, merge only when none are left open)