-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert to wkw unit support #7970
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Backend LGTM, and works for me :) Just see my comment on parameter naming at https://github.com/scalableminds/voxelytics/pull/3666#discussion_r1703688121 which should also be applied here.
And while reviewing please use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
front-end lgtm :)
WK part to enable passing the user-provided unit to the wkw conversion job.
Please note that I tried to improve the typing and naming of the upload view in the frontend :). This just slipped in as an improvement.
URL of deployed dev instance (used for testing):
Steps to test:
yarn enable-jobs
)Issues:
(Please delete unneeded items, merge only when none are left open)