-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow alignment job to take matches from skeleton into account #7967
Conversation
…gnment_with_annotations
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR @Tobias314,
I only found minor things. Well done :) The only must change form my side would be the renaming of the skeleton form item. Please see my comment for that.
Additionally I want to double check something with @fm3 :)
Edit: And maybe also the additional check for an empty skeleton tracing. I just managed to submit the job with the check mark set at the new form item, but with an empty skeleton tracing. I'd welcome a error in such a case :)
frontend/javascripts/oxalis/view/action-bar/starting_job_modals.tsx
Outdated
Show resolved
Hide resolved
frontend/javascripts/oxalis/view/action-bar/starting_job_modals.tsx
Outdated
Show resolved
Hide resolved
frontend/javascripts/oxalis/view/action-bar/starting_job_modals.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, @Tobias314 I found another few nitpicky suggestions about variable naming. Afterwards this PR should be good to go :)
Please apply them before merging
frontend/javascripts/oxalis/view/action-bar/starting_job_modals.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: MichaelBuessemeyer <[email protected]>
…gnment_with_annotations
…/webknossos into alignment_with_annotations
Description:
Steps to test:
TODOs:
Issues: