Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-expand relevant groups when focussing segment #7950

Merged
merged 10 commits into from
Jul 29, 2024

Conversation

dieknolle3333
Copy link
Contributor

@dieknolle3333 dieknolle3333 commented Jul 25, 2024

URL of deployed dev instance (used for testing):

Steps to test:

  • open an annotation and go to segments tab
  • focus a segment, remember where it is in the viewport
  • close the containing group (must not be root group)
  • click on segment in view port, open context menu and "focus segment in list"
  • see that containing group is opened again and that segment is focused in list

other changes

  • moreover, the root group in the segment tab is now always expanded

TODOs:

  • fix that SwitcherIcon is still displayed

Issues:


(Please delete unneeded items, merge only when none are left open)

@dieknolle3333 dieknolle3333 self-assigned this Jul 25, 2024
@dieknolle3333 dieknolle3333 marked this pull request as ready for review July 26, 2024 12:18
Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool! just two comments:

@philippotto philippotto changed the title Focus segment in collapsed group (for real) Auto-expand relevant groups when focussing segment Jul 29, 2024
@philippotto
Copy link
Member

I changed the PR title to be a bit more precise, since this will become the commit message eventually :)

@dieknolle3333
Copy link
Contributor Author

I changed the PR title to be a bit more precise, since this will become the commit message eventually :)

thank you 🙏 👍

Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, works very well 👍 Only do the one renaming I commented :)

@dieknolle3333 dieknolle3333 enabled auto-merge (squash) July 29, 2024 11:26
@dieknolle3333 dieknolle3333 merged commit 1333f7e into master Jul 29, 2024
2 checks passed
@dieknolle3333 dieknolle3333 deleted the focus-segment-in-collapsed-group-for-real branch July 29, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Focus in segment list for segments in a collapsed group
2 participants