-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show clicked Bounding Box in BB-Tab #7935
Show clicked Bounding Box in BB-Tab #7935
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely done, works very well 👍
One more thing that came to my mind, because the view is not the fastest having 20+ bounding boxes (also hasn't been before!): Now that an antd table is used one could try to set the virtual
prop and check whether that improves performance. There's no need to do that in this PR, but if you'd like you can try.
frontend/javascripts/oxalis/view/components/setting_input_views.tsx
Outdated
Show resolved
Hide resolved
Sorry @daniel-wer, but I did some code adjustments that need your review:
I also tested making the table virtualized but stopped doing so, as it sadly requires setting a specified scroll width and height. In order to get the correct values of width and height I would have needed something like hardcoded calculation of the tab's current width and height. This is due to the tab being resizable. As I wanted to avoid this rather ugly code, I undid my changes and kept the table in a not virtualized state. So this remains a future TODO. Could you please recheck the newest version of this PR @daniel-wer |
And @daniel-wer what do you think about this:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Thank you for testing the virtualization! I second your opinion that it's best to look at that as a followup.
Should the context menu support to highlight a bounding box?
I don't think that is necessary as simply clicking on the bounding box will highlight it in the list.
…ow-having-selected-bounding-box
URL of deployed dev instance (used for testing):
Steps to test:
TODOs:
Open Questions
Issues:
(Please delete unneeded items, merge only when none are left open)