Show wk user in vx workflow list and enable cache busting for bundle chunks #7854

dieknolle3333 · 2024-06-03T20:02:32Z

New attempt to merge old PR #7794 after deployment didnt show the right changes. We found out that the JS bundles are chunked, and the chunk that holds the changes of this PR did not include any cache busting mechanism.

Changes beside old PR:

include commit hash in name of webpack entry points (because scala doesnt know content hash)
- introduce new library, that does not contain any dependencies itself
include content hash in name of chunked bundles to introduce cache busting

URL of deployed dev instance (used for testing):

https://backupshowwkuserinvxworkflowlist.webknossos.xyz/workflows (not latest changes of branch, because it contains mock data. Includes cache busting fix.)

Steps to test:

go to workflow view and see wk users

ToDos

explore whether double request can be avoided

Issues:

fixes Show WK user name next to owner in voxelytics workflows list #7735

(Please delete unneeded items, merge only when none are left open)

Updated changelog
Updated migration guide if applicable
Updated documentation if applicable
Adapted wk-libs python client if relevant API parts change
Removed dev-only changes like prints and application.conf edits
Considered common edge cases
Needs datastore update after deployment

…tend

… image

…x-workflow-list

…endencies

dieknolle3333 · 2024-06-05T15:52:04Z

yarn.lock

+"string-width-cjs@npm:string-width@^4.2.0":
+  version "4.2.3"
+  resolved "https://registry.yarnpkg.com/string-width/-/string-width-4.2.3.tgz#269c7117d27b05ad2e536830a8ec895ef9c6d010"
+  integrity sha512-wKyQRQpjJ0sIp62ErSZdGsjMJWsap5oRNihHhu6G7JVO/9jIB6UyevL+tXuOqrng8j/cxKTWyWUwvSTriiZz/g==
+  dependencies:
+    emoji-regex "^8.0.0"
+    is-fullwidth-code-point "^3.0.0"
+    strip-ansi "^6.0.1"
+
+string-width@^4.0.0, string-width@^4.2.2, string-width@^4.2.3:


we think this might be due to changes that happened during yarn add / yarn install and that this shouldnt be a problem.

dieknolle3333 · 2024-06-05T20:42:23Z

frontend/javascripts/admin/voxelytics/workflow_list_view.tsx

@@ -84,9 +89,18 @@ export default function WorkflowListView() {
    }
  }

-  usePolling(loadData, VX_POLLING_INTERVAL);
+  usePolling(async () => {


@fm3 I tried to address your comment about requesting the workflows twice while trying not to mess around in the code too much. I thought I could delete the loadData call where the search query is persisted, but then a dataless page is rendered. So I think this check here might be an acceptable solution for now, especially because the interval is set to null, but I am keen to hear what you say :)

hotzenklotz

webpack changes look good to me.

hotzenklotz

LGTM

fm3

Awesome, thanks for investigating the cache problems! Weird of the browsers that ctrl+shift+r cache clear apparently did not work for the sub-bundles…

I created a follow-up issue to properly clean up the pollingcode #7862

I’ll add a changelog entry to mention the cache fix. Then this should be good to go :)

dieknolle3333 added 30 commits May 8, 2024 18:19

try to adjust backend by passing through the wk user id

d17c9b2

WIP [ci skip] start to show wk user

9239245

join with webknossos.user_ table to get user first and lastname

fda5743

remove wk user id

13c2f39

show merged username and have host name as backup

4488e31

Merge branch 'master' into show-wk-user-in-vx-workflow-list

ff1bc0b

adjust SQL query and typing more; improve user name rendering in fron…

ced9106

…tend

display wk user name

74d770f

change typing to remove cast

5d56383

fix type errors

8a067f7

Merge branch 'master' into show-wk-user-in-vx-workflow-list

46c771c

add changelog

c16deb2

improve changelog

d74759f

remove comments

df70035

implement filter

bbb4984

revert application.conf edits

17c3e80

fix typing

60ef98f

improve key

8eb8c39

Merge branch 'master' into show-wk-user-in-vx-workflow-list

eb6f379

unify camel case in WorkflowListingRunEntry and RunEntry

832eb0d

WIP: address review in frontend

b1e0040

make wk user optional

f742567

format

8d7a205

revert type reverts

67be5af

improve scala camel case

26e9cda

remove renaming from SQL code

57d0bcb

revert application.conf edit

9e174b0

merge master

7ad79ce

fix sorting of runs

ad5731e

Merge branch 'master' into show-wk-user-in-vx-workflow-list

f734897

dieknolle3333 added 6 commits May 30, 2024 16:07

revert application.conf edit

614de75

Merge branch 'master' into show-wk-user-in-vx-workflow-list

e7fb0f8

fix camel case of host name

9151c8f

change application.config

b07d68e

lint

67de20c

revert application.conf edits to make pipeline green to create docker…

b7b62be

… image

dieknolle3333 self-assigned this Jun 4, 2024

add mock data

553cc4f

MichaelBuessemeyer force-pushed the backup-show-wk-user-in-vx-workflow-list branch from 877eafa to 553cc4f Compare June 5, 2024 10:58

apply fix to not cache bundle chunk files to backup-show-wk-user-in-v…

6acc3b7

…x-workflow-list

MichaelBuessemeyer force-pushed the backup-show-wk-user-in-vx-workflow-list branch from 74083e9 to 6acc3b7 Compare June 5, 2024 14:10

MichaelBuessemeyer and others added 2 commits June 5, 2024 16:30

move git commit hash loading dep for webpack build process to dev dep…

5a2e1be

…endencies

undo dev changes

3f50bda

dieknolle3333 assigned MichaelBuessemeyer Jun 5, 2024

dieknolle3333 commented Jun 5, 2024

View reviewed changes

dieknolle3333 added 2 commits June 5, 2024 17:55

adjust formatting

1720d12

Merge branch 'master' into backup-show-wk-user-in-vx-workflow-list

f0fcaaa

dieknolle3333 changed the title ~~Backup show wk user in vx workflow list~~ Show wk user in vx workflow list and enable cache busting for bundle chunks Jun 5, 2024

dieknolle3333 marked this pull request as ready for review June 5, 2024 16:06

dieknolle3333 requested a review from fm3 June 5, 2024 16:06

remove redundant initial data fetch

0d0884a

dieknolle3333 commented Jun 5, 2024

View reviewed changes

hotzenklotz reviewed Jun 6, 2024

View reviewed changes

hotzenklotz approved these changes Jun 6, 2024

View reviewed changes

fm3 reviewed Jun 6, 2024

View reviewed changes

changelog

c78a91d

fm3 enabled auto-merge (squash) June 6, 2024 11:06

fm3 merged commit 281855f into master Jun 6, 2024
2 checks passed

fm3 deleted the backup-show-wk-user-in-vx-workflow-list branch June 6, 2024 11:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Show wk user in vx workflow list and enable cache busting for bundle chunks #7854

Show wk user in vx workflow list and enable cache busting for bundle chunks #7854

dieknolle3333 commented Jun 3, 2024 •

edited

Loading

dieknolle3333 Jun 5, 2024 •

edited

Loading

dieknolle3333 Jun 5, 2024 •

edited

Loading

hotzenklotz left a comment

hotzenklotz left a comment

fm3 left a comment •

edited

Loading

Show wk user in vx workflow list and enable cache busting for bundle chunks #7854

Show wk user in vx workflow list and enable cache busting for bundle chunks #7854

Conversation

dieknolle3333 commented Jun 3, 2024 • edited Loading

URL of deployed dev instance (used for testing):

Steps to test:

ToDos

Issues:

dieknolle3333 Jun 5, 2024 • edited Loading

Choose a reason for hiding this comment

dieknolle3333 Jun 5, 2024 • edited Loading

Choose a reason for hiding this comment

hotzenklotz left a comment

Choose a reason for hiding this comment

hotzenklotz left a comment

Choose a reason for hiding this comment

fm3 left a comment • edited Loading

Choose a reason for hiding this comment

dieknolle3333 commented Jun 3, 2024 •

edited

Loading

dieknolle3333 Jun 5, 2024 •

edited

Loading

dieknolle3333 Jun 5, 2024 •

edited

Loading

fm3 left a comment •

edited

Loading