Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix timespan summing for annotations due to annotationLayer join #7787

Merged
merged 2 commits into from
May 7, 2024

Conversation

fm3
Copy link
Member

@fm3 fm3 commented May 7, 2024

Joining in the annotation layers created duplicate entries for annotations with multiple layers (most of them). This would result in their timespans being counted twice for the SUM.

Extracting this into a WITH statement fixes that.

URL of deployed dev instance (used for testing):

Steps to test:

  • Create some annotations, trace some
  • Timetracking should show sensible values (user sum should be sum of user annotations)

Issues:


@fm3 fm3 self-assigned this May 7, 2024
@fm3 fm3 marked this pull request as ready for review May 7, 2024 08:29
Copy link
Contributor

@MichaelBuessemeyer MichaelBuessemeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this 🙏

The dev instance does not appear to have the bug present.

I also tested locally and compared this branch with the master. By doing so I was able to confirm the bug on the master and that this PR / branch fixes the bug 🚀

@fm3 fm3 merged commit 708a02f into master May 7, 2024
2 checks passed
@fm3 fm3 deleted the time-tracking-fix-join branch May 7, 2024 09:41
dieknolle3333 pushed a commit that referenced this pull request May 8, 2024
* Fix timespan summing for annotations due to annotationLayer join

* changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants