Make markdown modal faster (e.g., editing of annotation description) #7769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hotzenklotz
reviewed
Apr 24, 2024
| @@ -59,12 +59,20 @@ class EditableTextLabel extends React.PureComponent<EditableTextLabelProp, State | |||
| } | |||
| } | |||
|
|
|||
| handleInputChange = (event: React.ChangeEvent<HTMLTextAreaElement | HTMLInputElement>) => { | |||
| handleInputChangeFromEvent = ( | |||
There was a problem hiding this comment.
Why does the component have two change handlers? Just for type safety?
There was a problem hiding this comment.
The component can use the MarkdownModal as well as the usual Input component. Since I changed the MarkdownModal to not use the event parameter anymore, the parent component now needs both variants. It's a bit unfortunate, but still the best trade-off in my opinion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
URL of deployed dev instance (used for testing):
Steps to test:
Issues:
(Please delete unneeded items, merge only when none are left open)