Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added type definitions for react-remarkable #7748

Merged
merged 6 commits into from
Apr 15, 2024
Merged

Conversation

hotzenklotz
Copy link
Member

@hotzenklotz hotzenklotz commented Apr 11, 2024

I added type definitions for the react-remarkable package. Unfortunately, there were not @types/react-remarkable definitions available to I had to write my own.

Steps to test:

  • Run type checker
  • CI should be enough

(Please delete unneeded items, merge only when none are left open)

Copy link
Contributor

@MichaelBuessemeyer MichaelBuessemeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the type and improving the typing 🙏

I only found one minor thing, regarding the defined type.
If you disagree with me there, feel free to merge this pr without the small suggestion :)

frontend/javascripts/types/react-remarkable.d.ts Outdated Show resolved Hide resolved
@hotzenklotz hotzenklotz enabled auto-merge (squash) April 15, 2024 15:23
@hotzenklotz hotzenklotz merged commit c47cd65 into master Apr 15, 2024
2 checks passed
@hotzenklotz hotzenklotz deleted the types-react-remarkable branch April 15, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants