-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use new mesh API for animation job #7692
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
didn't test yet, but looks good already 👍 added some minor comments.
frontend/javascripts/oxalis/view/action-bar/create_animation_modal.tsx
Outdated
Show resolved
Hide resolved
} | ||
} | ||
// Submit currently visible pre-computed & ad-hoc meshes | ||
const axis = ""; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
const axis = ""; | |
// Currently, additional coordinates are not supported for this rendering job | |
const axis = getAdditionalCoordinatesAsString([]); |
would be a bit cleaner.
frontend/javascripts/oxalis/view/action-bar/create_animation_modal.tsx
Outdated
Show resolved
Hide resolved
app/controllers/JobsController.scala
Outdated
"layer_name" -> animationJobOptions.layerName, | ||
"segmentation_layer_name" -> animationJobOptions.segmentationLayerName, | ||
"is_view_mode" -> animationJobOptions.isViewMode, | ||
"color_layer_name" -> animationJobOptions.colorLayerName, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note that if the command args change, the job list view code in the frontend also needs to be adapted (currently the existing layer_name is used to render the job description. compare also getJobs in admin_rest_api
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we also need to ensure backwards compatibility for this job list view rendering (or migrate old jobs in postgres)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. I wasn't aware of this connection... will undo the renaming then.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested again and most cases work for me now 🎉
I noticed two more small problems
This message already crops up on pageload when viewing a dataset without color layers. It would be nice if that would happen only once you actually clicked on create animation.
And: sometimes seedAdditionalCoordinates
is not included in the mesh info json (in my test this happened in a proofreading annotation). Since the python code expects this field to be present (although null is a valid option), it fails at that point. Not sure if it should be adapted here or there.
I fixed this.
I have a hard time to reproduce this. I played around with proofreading annotations but the request always includes a an empty array for the |
I think, it would be easiest to adapt the python code so that a missing value is also okay. Alternatively, we would need to turn Without doing one of these options, rare hiccups are bound to happen at some point, since the property is typed as "may be missing". |
This PR adds support for passing the required mesh information to use mesh API (PR #7587)for animation jobs.
URL of deployed dev instance (used for testing):
Steps to test:
TODOs:
Issues:
(Please delete unneeded items, merge only when none are left open)