Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adds support for more omero info keys #7685

Merged
merged 3 commits into from
Mar 14, 2024
Merged

adds support for more omero info keys #7685

merged 3 commits into from
Mar 14, 2024

Conversation

normanrz
Copy link
Member

@normanrz normanrz commented Mar 13, 2024 •
edited
Loading

Adds histogram range, isDisabled and isInverted from the omero info in the NGFF metadata.

Steps to test:

Issues:

(Please delete unneeded items, merge only when none are left open)

  • Updated changelog
  • Needs datastore update after deployment

@normanrz normanrz requested a review from frcroth March 13, 2024 17:06
@normanrz normanrz self-assigned this Mar 13, 2024
@normanrz normanrz requested a review from fm3 March 13, 2024 17:29
fm3
fm3 approved these changes Mar 14, 2024
View reviewed changes
Copy link
Member

@fm3 fm3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Did you test it with a dataset that has this info, and also with one that doesn’t have it? (to check if the empty codepath also works)?

@normanrz normanrz merged commit cb139ad into master Mar 14, 2024
2 checks passed
@normanrz normanrz deleted the ngff-omero-info branch March 14, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fm3 fm3 fm3 approved these changes

@frcroth frcroth Awaiting requested review from frcroth

Assignees

@normanrz normanrz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NGFF Explorer: read omero channel metadata, write layer view configuration
2 participants
@normanrz @fm3