Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In proofreading min-cut, return directed edges to keep id of selected #7608

Merged
merged 2 commits into from
Feb 7, 2024

Conversation

fm3
Copy link
Member

@fm3 fm3 commented Feb 7, 2024

Min-cut returns a set of edges that are then passed to the proofreading split operation. These edges need to be directed so that when splitting the expected side keeps its agglomerate id. This PR uses the min cut’s source partition to determine which way the edges should be directed.

Steps to test:

  • In proofreading annotation, perform a split one way, merge again, perform the split the other way, repeat. Always the selected (first-clicked, cross-bearing) segment should keep its agglomerate id
  • For merging this should have already worked, do some testing for that too

Issues:


@fm3 fm3 marked this pull request as ready for review February 7, 2024 10:39
@fm3 fm3 self-assigned this Feb 7, 2024
@fm3 fm3 requested a review from philippotto February 7, 2024 10:40
Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Works as expected 👍

@fm3 fm3 merged commit 8b09fbc into master Feb 7, 2024
2 checks passed
@fm3 fm3 deleted the min-cut-directed branch February 7, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Proofreading] Keep color of active segment when splitting/merging
2 participants