Disable CSP by default #7589
Merged
Disable CSP by default #7589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-wer
reviewed
Feb 5, 2024
There was a problem hiding this comment.
I can follow the reasoning 👍
Could you open a PR in the kube repository adapting the config for our dev instances and wk.org. The comments that are no longer relevant for the application.conf could also be moved there (the ones concerning the dev setup can be removed of course).
hotzenklotz
approved these changes
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#7367 and #7450 added CSP support to WEBKNOSSOS. For our production and hosted dev instances this is a win for security. However, for dev purposes (e.g. in a local network) and our open-source users, this adds substantial friction. This PR proposes to effectively disable CSP by default. We'll of course keep stricter rules for our hosted instances.
Happy to discuss and hear your feedback.
(Please delete unneeded items, merge only when none are left open)