Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "Download Meshes" functionality #7577

Merged
merged 4 commits into from
Jan 23, 2024
Merged

Fix "Download Meshes" functionality #7577

merged 4 commits into from
Jan 23, 2024

Conversation

daniel-wer
Copy link
Member

@daniel-wer daniel-wer commented Jan 22, 2024

Avoid that zip.js dynamically creates a web worker using new Blob(...) which violates the CSP.
The z-worker.js seems to be requested for each mesh 🤷 but it's cached so it shouldn't be an issue.

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • Load a couple of meshes
  • Use "Download Meshes" in the context menu of a group in the segments tab (this fails on master due to CSP)
  • Check that the single mesh download still works

(Please delete unneeded items, merge only when none are left open)

@daniel-wer daniel-wer self-assigned this Jan 22, 2024
Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this! 🙏 Changes LGTM. I didn't test it (CI is not ready yet), but I trust that you did so and wanted to leave an approval already.

Copy link
Contributor

@dieknolle3333 dieknolle3333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works great for me, thanks for looking into this :)

@daniel-wer daniel-wer merged commit fcded1c into master Jan 23, 2024
2 checks passed
@daniel-wer daniel-wer deleted the fix-download-meshes branch January 23, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants