Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Play 3 #7562

Merged
merged 7 commits into from
Jan 22, 2024
Merged

Upgrade to Play 3 #7562

merged 7 commits into from
Jan 22, 2024

Conversation

frcroth
Copy link
Member

@frcroth frcroth commented Jan 17, 2024 •
edited
Loading

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

Anything specific that should be tested? Going through some common features (e.g. loading datasets remote/local...) works.

TODOS:

  • Investigate test failure
  • Migration guide

Issues:

(Please delete unneeded items, merge only when none are left open)

@frcroth frcroth marked this pull request as ready for review January 17, 2024 13:25
@frcroth frcroth requested a review from fm3 January 17, 2024 13:25
fm3
fm3 reviewed Jan 17, 2024
View reviewed changes
Copy link
Member

@fm3 fm3 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet! I’ll do some testing on some more things that come to mind

  • scheduled clean up jobs
  • requesting ad-hoc meshes

Could you add a migration guide entry noting the changed config keys in the .conf files?

@fm3 fm3 assigned fm3 and frcroth Jan 18, 2024
@frcroth frcroth requested a review from fm3 January 22, 2024 10:51
fm3
fm3 approved these changes Jan 22, 2024
View reviewed changes
Copy link
Member

@fm3 fm3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@frcroth frcroth merged commit 87c21ba into master Jan 22, 2024
2 checks passed
@frcroth frcroth deleted the play3 branch January 22, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fm3 fm3 fm3 approved these changes

Assignees

@fm3 fm3

@frcroth frcroth

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade to Play 3 and Pekko
2 participants
@frcroth @fm3