Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use orga and project owner emails to notify #7561

Merged
merged 7 commits into from
Jan 22, 2024
Merged

Use orga and project owner emails to notify #7561

merged 7 commits into from
Jan 22, 2024

Conversation

frcroth
Copy link
Member

@frcroth frcroth commented Jan 17, 2024 •
edited
Loading

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • Set logToStdOut in application.conf to true
  • create an invite and accept it. -> The org owner will get an email (even though none is configured)
  • Not sure how to test the overtime stuff

TODOs:

  • ...

Issues:

(Please delete unneeded items, merge only when none are left open)

@frcroth frcroth changed the title Use orga owner mail when mailing lists are unspecified Use orga and project owner emails to notify Jan 17, 2024
@frcroth frcroth marked this pull request as ready for review January 17, 2024 12:22
@frcroth frcroth requested a review from fm3 January 17, 2024 12:22
fm3
fm3 reviewed Jan 22, 2024
View reviewed changes
Copy link
Member

@fm3 fm3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM, just added some comments about cosmetics

app/controllers/AuthenticationController.scala Outdated Show resolved Hide resolved
app/mail/DefaultMails.scala Outdated Show resolved Hide resolved
app/models/organization/OrganizationService.scala Outdated Show resolved Hide resolved
@frcroth frcroth requested a review from fm3 January 22, 2024 14:36
@frcroth frcroth merged commit 9187eff into master Jan 22, 2024
2 checks passed
@frcroth frcroth deleted the fallback-on-orga-owner-mail branch January 22, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fm3 fm3 fm3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@frcroth @fm3