Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make isValidNewName route always return 200 #7550

Merged
merged 10 commits into from
Jan 17, 2024
Merged

Conversation

frcroth
Copy link
Member

@frcroth frcroth commented Jan 15, 2024

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • click on "Add Dataset" in dashboard
  • type a name into the "Dataset Name" field that already exists for another ds -> red label should appear
  • change name to something unique -> error should disappear
  • no error toast should appear during the above

TODOs:

  • Since it is not user facing, no Changelog, only migration?

Issues:


(Please delete unneeded items, merge only when none are left open)

@frcroth frcroth changed the title Add new isValidNewName route and increment api version Make isValidNewName route always return 200 Jan 15, 2024
@frcroth frcroth marked this pull request as ready for review January 15, 2024 16:00
@frcroth frcroth requested a review from fm3 January 15, 2024 16:00
Copy link
Member

@fm3 fm3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backend LGTM :) @philippotto could you have a look at the frontend (and fix it if needed)? My guess is that showErrorToast: false is no longer needed, since in normal operation there should no longer be an error 400 here.

@frcroth I think it would be nice to add a short changelog entry, if only for ourselves to note that the API version changed here. Also I’m afraid I caused some small merge conflicts with #7552 😅

Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure! I pushed a small commit. testing went well 🚀

@frcroth frcroth merged commit 599114c into master Jan 17, 2024
2 checks passed
@frcroth frcroth deleted the isValidNewName-200 branch January 17, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dataset isValidNewName route should always return 200, with true/false body
3 participants