-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make isValidNewName route always return 200 #7550
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Backend LGTM :) @philippotto could you have a look at the frontend (and fix it if needed)? My guess is that showErrorToast: false is no longer needed, since in normal operation there should no longer be an error 400 here.
@frcroth I think it would be nice to add a short changelog entry, if only for ourselves to note that the API version changed here. Also I’m afraid I caused some small merge conflicts with #7552 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure! I pushed a small commit. testing went well 🚀
URL of deployed dev instance (used for testing):
Steps to test:
TODOs:
Issues:
(Please delete unneeded items, merge only when none are left open)