-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show Annotation Segment Counts in Dashboard #7548
Conversation
@fm3 The frontend should send the segmentCount now. The dashboard receives |
Great, thanks! Yes, I moved the stats to the annotation layers inside of the annotation json. They should ™️ already be filled, but I did not test this end-to-end yet. |
Yeah, seems to work :) Note that the stats in the layers may also still be Do you think the dashboard frontend code can work with this new format? |
…sos into save-segment-stats
Cool, I adapted the dashboard now. What's up with the old |
Yes, it’s always empty now. Removing it completely may break old libs clients. Feel free to remove it from the frontend types. I plan to remove it from the json in a later version. |
@philippotto thanks for taking care of the frontend! Do you think it would be possible to hide the segments if the annotation has no volume layer, and hide the tree count if the annotation has no skeleton layer? This way the user could notice at a glance what kind of annotation they have? (I’m also thinking that we might want to remove the skeleton/volume/hybrid tag from the dashboard in the future, because especially “hybrid” is explained nowhere) I think the backend is ready for review, feel free to request reviews when you think this is done :) |
…notation is present
Yes, good points 👍 It's done now. |
…sos into save-segment-stats
…sos into save-segment-stats
…sos into save-segment-stats
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The frontend code looks very good 👍. I came up with one suggestion to make the code DRYer.
My testing also showed that the feature seems to work seamlessly.
I'd say, the frontend is merge ready 🚢
@frcroth Could you please approve this PR once everything looks good in the backend part?
frontend/javascripts/oxalis/model/accessors/annotation_accessor.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
URL of deployed dev instance (used for testing):
Steps to test:
TODOs:
[ ] Show infos for all layers in tooltip?Philipp: Not important for now{}
after merge, create from task, upload)Issues: