Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for ComputeSegmentIndexFile worker job #7471

Merged
merged 7 commits into from
Dec 5, 2023

Conversation

hotzenklotz
Copy link
Member

@hotzenklotz hotzenklotz commented Dec 4, 2023

This PR adds support for triggering the ComputeSegmentIndexFile worker job through a REST route. This is very similar to the the ComputeMeshFile job.

UI Changes:

  • A button to trigger this worker job for superusers
  • Proper listings on the jobs page

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

Use the button (only visible for superusers) or send a POST request (needs auth cookie), e.g.:

curl 'http://localhost:9000/api/jobs/run/computeSegmentIndexFile/sample_organization/Sample_e2006_wkw?layerName=segmentation&mag=64-64-64' \
  -X 'POST' \
  -H 'Content-Length: 0' \
  -H 'Cookie: id=1-12345678' \
  -H 'Origin: http://localhost:9000' \
  -H 'Referer: http://localhost:9000/datasets/sample_organization/Sample_e2006_wkw/view' \
  -H 'Sec-Fetch-Dest: empty' \
  -H 'Sec-Fetch-Mode: cors' \
  -H 'Sec-Fetch-Site: same-origin' \
  -H 'accept: application/json' \

TODOs:

  • Job listing in the UI requires some love. Alternatively, hide this entry altogether.
image

Issues:


(Please delete unneeded items, merge only when none are left open)

@@ -152,7 +152,7 @@ WEBKNOSSOS requires several metadata properties for each dataset to properly dis
+ `dataLayers.largestSegmentId`: The highest ID that is currently used in the respective segmentation layer. This is required for volume annotations where new objects with incrementing IDs are created. Only applies to segmentation layers.
+ `dataLayers.dataFormat`: Should be `wkw`.

#### NML Files
### NML Files
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somewhat unrelated change, but the indentation for this was one level too deep.

@hotzenklotz hotzenklotz marked this pull request as ready for review December 4, 2023 15:22
@hotzenklotz
Copy link
Member Author

@philippotto Can you please have a quick look at the frontend changes. NO need to deep test this with the worker running. Thanks.

Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the front-end looks good to me 👍

@hotzenklotz hotzenklotz enabled auto-merge (squash) December 5, 2023 15:05
@hotzenklotz hotzenklotz merged commit 653436d into master Dec 5, 2023
2 checks passed
@hotzenklotz hotzenklotz deleted the segment_index_worker_job branch December 5, 2023 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants