Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a delete dataset action to dashboard #7448

Merged
merged 19 commits into from
Mar 11, 2024
Merged

Conversation

hotzenklotz
Copy link
Member

@hotzenklotz hotzenklotz commented Nov 21, 2023

Every now and again there appear old, unimported datasets on your dashboard, mostly on WK instance with file system access. Thus far there is no easy way to delete them. This PR adds a "Delete" action to these unimported datasets.

I had to refactor the dataset action view into a React function component in order to use the query hooks. Unfortunately, Git does not track the changes very well.

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  1. Duplicate any DS in your binaryData folder and remove datasource-porps.json to make it go kaputt
  2. Re-scan datasets on your dashboard
  3. See and press "Delete" action
  4. Profit

Issues:

  • None

(Please delete unneeded items, merge only when none are left open)

@hotzenklotz hotzenklotz self-assigned this Nov 21, 2023
@hotzenklotz
Copy link
Member Author

hotzenklotz commented Nov 29, 2023

Blocked by #7429

@hotzenklotz hotzenklotz marked this pull request as ready for review March 7, 2024 10:00
Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, works well 👍

@hotzenklotz hotzenklotz enabled auto-merge (squash) March 11, 2024 09:46
@hotzenklotz hotzenklotz merged commit 9867294 into master Mar 11, 2024
2 checks passed
@hotzenklotz hotzenklotz deleted the delete-dataset-dashboard branch March 11, 2024 15:32
@philippotto philippotto mentioned this pull request May 29, 2024
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants