Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't delete dataset in DB when annotations exist #7429

Merged
merged 20 commits into from
Dec 6, 2023
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,17 @@ class DatasetActionView extends React.PureComponent<Props, State> {
onClick={() =>
Modal.error({
title: "Cannot load this dataset",
content: dataset.status,
content: (
<div>
<p>{dataset.status}</p>
{dataset.status === "Deleted by user." ? (
<p>
Even though, this dataset was deleted by a user, it is still shown here,
because it is referenced by at least one annotation.
</p>
) : null}
</div>
),
})
}
>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ const DatasetSettingsDeleteTab = ({ datasetId, history }: Props) => {
}

const deleteDataset = await confirmAsync({
title: `Deleting a dataset on disk cannot be undone. Are you certain to delete dataset ${dataset.name}?`,
title: `Deleting a dataset on disk cannot be undone. Are you certain to delete dataset ${dataset.name}? Note that the name of a dataset is not guaranteed to be free to use afterwards.`,
okText: "Yes, Delete Dataset on Disk now",
});

Expand Down