-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to compose datasets without transforms or with bigwarp/NML landmarks #7395
Conversation
webknossos-datastore/app/com/scalableminds/webknossos/datastore/services/ComposeService.scala
Outdated
Show resolved
Hide resolved
frontend/javascripts/admin/dataset/dataset_add_compose_view.tsx
Outdated
Show resolved
Hide resolved
…ry (due to empty NMLs)
Hmm, this is weird. It works for me. Can you check the network tab and understand why the dataset can't be found? Happy to debug this together in a call 🤙
I made the component an async one to avoid that all datasets have to be fetched. Instead, the same search api is used as in the dashboard. To reduce the confusion I changed two things:
It's not perfect, but I can't think of a better way right now without fetching possibly thousands of datasets in this UI. I hope this is okay? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Backend LGTM :)
@philippotto Thanks for addressing my feedback! The added format instructions will be very helpful to users I would imagine.
This turned out to be an sql issue of the dev deployment. I wrongly assumed I was the first to deploy the branch at the time, but it was deployed earlier and the schemaVersion became incompatible. After a re-deployment, this works well 👍
This mostly works well and addresses my issue, but a small nuisance now is that typing and then clicking anywhere but on a dataset entry will clear the search box. I'm not sure whether that's important, but if you see a quick fix, feel free. One optional suggestion would be to use toggles to disable layers in the layer selection screen, because it would allow users to change their mind (going back one screen and next again, resets all values including the dataset name). @fm3 Feel free to test as well and/or approve if you are happy with this PR :) |
Hmm, this seems to be the default behavior in the select component from antd (see doc examples). I didn't find a way to avoid this (I tried
Good idea! However, I'd like to postpone this to another iteration :) We will certainly get more feedback when this feature is available in production and then we can priotize. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me :)
I think the first page of the wizard is a bit cumbersome. It contains three explanations, then a radio group with three buttons that mirror those, and then a next button. Instead it could be three clickable cards, where each starts one of the workflows, and which contain the explanations. To my mind that would be a way clearer UI.
However, this does not need to block this PR
@frcroth One more question: I see that the new case class |
Good point! We don't have off-the-shelf cards with a nice design yet. However, I decided to slim down the UI by directly inlining the radio buttons where the list was before. The description was somewhat redundant anyway (the next pages of the wizard explain what's needed better). I hope this is okay that way. |
Definitely better :) |
Should I wait with merging this PR? |
Can be a follow-up. I guess we can change the API later without issue, since it is not used except by our own frontend code |
Discussed here: https://scm.slack.com/archives/C5AKLAV0B/p1700831539308049?thread_ts=1697184159.482769&cid=C5AKLAV0B |
you’re right, I now wrote #7560 |
This PR adds the ability to compose a new dataset from existing dataset layers. There are three possibilities to do this:
The user is guided through these options in a wizard. Transforms are only generated for a pair of datasets (i.e., it is not yet possible to compose from more than two datasets).
Slack discussion
URL of deployed dev instance (used for testing):
Steps to test:
ROI2017_wkw_tiffs_1_wkw
andROI2017_wkw_tiffs_2_wkw
)Issues:
(Please delete unneeded items, merge only when none are left open)