Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix statistics bug and rename resolution methods to coarsest and finest #7355

Merged
merged 4 commits into from
Sep 26, 2023
Merged

fix statistics bug and rename resolution methods to coarsest and finest #7355

merged 4 commits into from
Sep 26, 2023

Conversation

dieknolle3333
Copy link
Contributor

@dieknolle3333 dieknolle3333 commented Sep 25, 2023 •
edited
Loading

I missed to places where lowestand highest resolution were mixed in the segment statistics modal. I fixed that and renamed the methods.
It also occured to us that the conversion from voxel to nm^3 was faulty, so this is also fixed for all segment stats.

Steps to test:

  • Create empty volume layer
  • Brush
  • Look at segment statistics modal and make sure the right volumes are displayed

(Please delete unneeded items, merge only when none are left open)

@dieknolle3333 dieknolle3333 self-assigned this Sep 25, 2023
@dieknolle3333 dieknolle3333 marked this pull request as ready for review September 25, 2023 13:42
fm3
fm3 reviewed Sep 25, 2023
View reviewed changes
Copy link
Member

@fm3 fm3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes the bug for me and LGTM. Thanks for looking into this so quickly!

I added one comment on naming. While this was not introduced in this PR, I think it should be changed to avoid future confusion.

frontend/javascripts/oxalis/view/context_menu.tsx Outdated Show resolved Hide resolved
@fm3
Copy link
Member

fm3 commented Sep 25, 2023 •
edited
Loading

Also, please add a changelog entry mentioning the bugfix :)

@dieknolle3333
Copy link
Contributor Author

thank you for the very fast review!

fm3
fm3 approved these changes Sep 26, 2023
View reviewed changes
Copy link
Member

@fm3 fm3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 😎

Could you adapt the PR description and changelog to briefly mention the faulty computation that this fixes?
Then this is good to go from my side

@dieknolle3333 dieknolle3333 merged commit 43d88dd into master Sep 26, 2023
1 check passed
@dieknolle3333 dieknolle3333 deleted the fix-resolution-naming branch September 26, 2023 08:46
@fm3 fm3 mentioned this pull request Sep 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fm3 fm3 fm3 approved these changes

Assignees

@dieknolle3333 dieknolle3333

Labels
bug frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dieknolle3333 @fm3