Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deleting selected segments #7316

Merged
merged 2 commits into from
Sep 6, 2023
Merged

Fix deleting selected segments #7316

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
090f12c
fix deleting selected segments
philippotto Sep 5, 2023
dfe990a
update changelog
philippotto Sep 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.unreleased.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ For upgrade instructions, please check the [migration guide](MIGRATIONS.released
- Adapted Zarr 3 implementations to recent changes in the specification (index codecs, zstd codec). [#7305](https://github.com/scalableminds/webknossos/pull/7305)

### Fixed
- Fixed that the deletion of a selected segment would crash the segments tab. [#7316](https://github.com/scalableminds/webknossos/pull/7316)

### Removed

Expand Down
12 changes: 12 additions & 0 deletions frontend/javascripts/oxalis/view/right-border-tabs/segments_tab/segments_view.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -510,10 +510,22 @@ class SegmentsView extends React.Component<Props, State> {
searchableTreeItemList.push(item);
});

const newSegmentIds = new Set(segments.map((segment) => segment.id));
const newGroupIds = new Set(segmentGroups.map((group) => group.groupId));
const oldSelectedGroupId = prevState.selectedIds.group;
updateStateObject = {
groupTree: generatedGroupTree,
searchableTreeItemList,
prevProps: nextProps,
selectedIds: {
// Ensure that the ids of previously selected segments are removed
// if these segments don't exist anymore.
segments: prevState.selectedIds.segments.filter((id) => newSegmentIds.has(id)),
group:
oldSelectedGroupId != null && newGroupIds.has(oldSelectedGroupId)
? oldSelectedGroupId
: null,
},
};
}
if (prevState.prevProps?.isosurfaces !== isosurfaces) {
Expand Down