Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AI-QuickSelect for ND datasets #7287

Merged
merged 159 commits into from
Sep 7, 2023
Merged

AI-QuickSelect for ND datasets #7287

merged 159 commits into from
Sep 7, 2023

Conversation

fm3
Copy link
Member

@fm3 fm3 commented Aug 17, 2023 •
edited
Loading

Steps to test:

TODOs:

  • Backend
    • route should take additionalCoordinates
    • should forward to datastore. fetch correct data
    • send optional basicauth to sam server
  • Frontend
    • Send correct additionalCoordinates in getSamEmbedding

Issues:

  • Updated changelog
  • Removed dev-only changes like prints and application.conf edits
  • Needs datastore update after deployment

philippotto and others added 30 commits June 12, 2023 14:50
@philippotto
add UI for 4th dimension and mock 4D data when requesting buckets
4f2be0e
@philippotto
adapt bucket address space to incorporate higher dimension
f80301b
@philippotto
clean up imports
3c8322a
@philippotto
add slider to Q input field; tune mocked 4D data retrieval
a24fb58
@philippotto
change max value of number slider
a38ece5
@philippotto
Merge branch 'master' of github.com:scalableminds/webknossos into 4d
e19dd4d
@philippotto
make skeletons compatible with higher dimensions
168d58e
@philippotto
fix tests; improve typing; create CubeEntry instances lazily
8dd6c5f
@philippotto
fix linting
082af8b
@philippotto
use n-dimensional generalization instead of fourth coordinate everywhere
7b30efe
@philippotto
fix resampling of buckets when annotating volume data in higher dimen…
6cc4372 
…sions
@philippotto
add additionalCoordinates parameter to several other places
5f11460
@philippotto
hardcode additionalCoords initialization
275c7af
@philippotto
tackle more todo comments
c25d61d
@philippotto
adapt additionalCoordinates input UI to arbitrary dimensions; use two…
38e0592 
… additional coordinates as hardcoded ones
@philippotto
dynamically generate shaders for nodes and edges to deal with arbitra…
b0b5b04 
…ry ND data
@philippotto
make edges interpolate from alpha 1 to 0 if edge partner is on other …
1f05545 
…dimension
@frcroth
Add additional coordinates for 4+D requests
6b7b3a5
@frcroth
Merge branch 'timeseries' into 4d
ff3e37b
@philippotto
begin integration of backend additionalCoordinate interface
54a4bf1
@philippotto
change frontend format for additional coordinates from number-array t…
48b1605 
…o array of objects (analoguous to backend)
@frcroth
Merge branch 'master' into 4d
bfe839c
@frcroth
Add additional coords to db
98c1e15
@frcroth
Fix naming
4c84670
@philippotto
Merge branch 'master' of github.com:scalableminds/webknossos into 4d
ce64fa9
@philippotto
remove hardcoded additional coordinates related to DataCube class
dad1652
@philippotto
properly initialize flycam with additional coordinates
e5047ce
@philippotto
make that arrow keys in vector input increment/decrement element wher…
2b819b0 
…e cursor is at
@philippotto
fix onChange in additional-coordinate-input
8f2eb14
@philippotto
use bounds of additional unified coordinates in slider
a63da9e
@fm3
Copy link
Member Author

fm3 commented Aug 28, 2023 •
edited
Loading

Awesome! I just tested it with the setup mentioned at https://scm.slack.com/archives/C5AKLAV0B/p1692289641525739?thread_ts=1692284968.544779&cid=C5AKLAV0B and it worked for me :)

Let’s wait until the main ND PR is merged, then we can continue with changelog etc and reviews here

@fm3 fm3 marked this pull request as ready for review August 28, 2023 14:08
@fm3 fm3 changed the title WIP: AI-QuickSelect for ND datasets AI-QuickSelect for ND datasets Aug 28, 2023
Base automatically changed from 4d to master September 5, 2023 08:12
@fm3 fm3 requested a review from frcroth September 5, 2023 09:46
@fm3 fm3 requested a review from frcroth September 5, 2023 13:05
@fm3 fm3 enabled auto-merge (squash) September 7, 2023 12:37
@fm3 fm3 merged commit ed78435 into master Sep 7, 2023
1 check passed
@fm3 fm3 deleted the nd-sam branch September 7, 2023 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frcroth frcroth frcroth approved these changes

Assignees

@fm3 fm3

Labels
backend enhancement frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Send Basic Auth Credentials to SAM server Support Quick Select AI tool for ND datasets
3 participants
@fm3 @philippotto @frcroth