Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add client_secret to oidc requests #7263

Merged
merged 2 commits into from
Aug 14, 2023
Merged

Add client_secret to oidc requests #7263

merged 2 commits into from
Aug 14, 2023

Conversation

fm3
Copy link
Member

@fm3 fm3 commented Aug 14, 2023

Steps to test:

  • Set up keycloak via docker-compose as described in Add OIDC authentication #6534 (comment) (Note that the admin user in keycloak needs first name, last name, email, which was missing by default when I tried this)
  • Adapt the client config in the keycloak UI to use Client authentication. A new tab “credentials” appears. Copy the client secret and add it in the application.conf
  • Also double-check the other values, especially publicKey, take that from Realm Settings → Keys in the keycloak UI
  • Also set features.openIdConnectEnabled = true in application.conf
  • Sign up/log in in webknossos using the OIDC button
  • Should work if client secret is correct, not work otherwise
  • Should also work if client secret is disabled in keycloak (set to emptystring in application.conf)

Issues:


@fm3 fm3 self-assigned this Aug 14, 2023
@fm3 fm3 changed the title WIP: add client_secret to oidc requests Add client_secret to oidc requests Aug 14, 2023
@fm3 fm3 marked this pull request as ready for review August 14, 2023 13:18
@fm3 fm3 requested a review from normanrz August 14, 2023 13:18
Copy link
Member

@normanrz normanrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice stuff!

@fm3 fm3 enabled auto-merge (squash) August 14, 2023 13:24
@fm3 fm3 merged commit 84887cd into master Aug 14, 2023
@fm3 fm3 deleted the oidc-client-secret branch August 14, 2023 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add OIDC client_secret-based authorization
2 participants