Segment multiselect #7242

dieknolle3333 · 2023-07-31T09:44:41Z

Steps to test:

Go to segments tab in any annotation, preferably one with a mesh file
Press shift and select more than one segment
Right-click to open the context menu like you are used to
Select any action you would like to execute on all selected segments, such as loading all meshes
Make sure this also works for meshes in different groups
Make sure all actions are working as expected
Make sure the visibility toggle for "Show /Hide meshes is working"
Make sure selecting a group after having selected multiple segments opens a toast with a warning like in the skeleton tab
After having selected meshes, open a group context menu and move all selected segments into the group

TODOs:

self-review code before making the PR ready-for-review
fix case where group is selected after having selected multiple segments, but ctrl is not pressed (currently missing warning toast)

Issues:

partly fixes Segments Groups #6954

(Please delete unneeded items, merge only when none are left open)

Updated changelog
Removed dev-only changes like prints and application.conf edits
Considered common edge cases

dieknolle3333 · 2023-07-31T09:58:50Z

frontend/javascripts/oxalis/view/right-border-tabs/segments_tab/segment_list_item.tsx

@@ -455,7 +457,7 @@ function _SegmentListItem({
        padding: "2px 5px",
      }}
      className={classnames("segment-list-item", {
-        "is-selected-cell": segment.id === selectedSegmentId,
+        "is-selected-cell": selectedSegmentIds?.includes(segment.id), //TODO this wont work


what exactly does this do? If I set it to false the segments are selected nonetheless?

(will delete the TODO comment obviously)

will test whether this can be deleted

so this actually makes the coloring a little better, but the box thats created while hovering has a different size than the box thats created upon selection, so I will see whether I can maybe improve this.

…gments and releasing ctrl

dieknolle3333 · 2023-07-31T14:19:40Z

frontend/javascripts/oxalis/view/right-border-tabs/segments_tab/segment_list_item.tsx

@@ -466,7 +465,11 @@ function _SegmentListItem({
      }}
    >
      <Dropdown


@philippotto I know we talked about increasing the zone where a segment item can be right-clicked by letting the dropdown be the parent of more content. I did not manage to do that however, because then the segment name would not react to the click anymore (so only the MeshInfoItem) – I had tried to include the MeshInfoItem into the dropdown.

philippotto

Didn't test yet, but looks pretty good already :)

CHANGELOG.unreleased.md

frontend/javascripts/oxalis/view/right-border-tabs/segments_tab/segment_list_item.tsx

frontend/javascripts/oxalis/view/right-border-tabs/segments_tab/segments_view.tsx

philippotto

Awesome, works really well 👍 Please merge on Monday :)

dieknolle3333 and others added 15 commits July 21, 2023 12:09

copy changes from old branch

93e439e

segment ids vs segment keys

361be14

WIP: implement functions for multiselect

b31717b

ignore select events when a popover a dropdown is open

b973570

implement reset color and remove segment from list batch actions

ef0fc83

add more batch actions such as show/hide meshes for multiselect

dd8d41f

fix visibility

5762493

recover group selection

1eb8e65

WIP: implement modal if group and segment are selected

1aa783b

WIP: actions on segments in different groups

b2338bb

get selected segments

87e8b1a

fix handledropdownvisibility

1740bf1

make linter happy(er)

e359eba

fix error that there is only one id for segment and group dropdown

c78e6a9

actually make segment and group dropdown id two fields

1d83cd3

dieknolle3333 commented Jul 31, 2023

View reviewed changes

dieknolle3333 added 4 commits July 31, 2023 15:33

delete dev remains

28b2baa

Merge branch 'master' into segment-multiselect

990b999

add changelog

02495cc

handle case where group is selected after having selected multiple se…

a465c40

…gments and releasing ctrl

dieknolle3333 marked this pull request as ready for review July 31, 2023 14:16

dieknolle3333 commented Jul 31, 2023

View reviewed changes

dieknolle3333 requested a review from philippotto July 31, 2023 14:21

dieknolle3333 self-assigned this Jul 31, 2023

improve comment

75c47c1

philippotto reviewed Jul 31, 2023

View reviewed changes

dieknolle3333 added 4 commits August 1, 2023 11:17

address review

62c2d11

adjust if-condition to improve performance

f68f9fb

improve regex

0d29c93

Merge branch 'master' into segment-multiselect

d5c5605

philippotto approved these changes Aug 4, 2023

View reviewed changes

dieknolle3333 merged commit 2d412fa into master Aug 7, 2023

dieknolle3333 deleted the segment-multiselect branch August 7, 2023 11:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Segment multiselect #7242

Segment multiselect #7242

dieknolle3333 commented Jul 31, 2023 •

edited

Loading

dieknolle3333 Jul 31, 2023

dieknolle3333 Jul 31, 2023

dieknolle3333 Jul 31, 2023

dieknolle3333 Jul 31, 2023

dieknolle3333 Jul 31, 2023 •

edited

Loading

philippotto left a comment

philippotto left a comment

Segment multiselect #7242

Segment multiselect #7242

Conversation

dieknolle3333 commented Jul 31, 2023 • edited Loading

Steps to test:

TODOs:

Issues:

dieknolle3333 Jul 31, 2023

Choose a reason for hiding this comment

dieknolle3333 Jul 31, 2023

Choose a reason for hiding this comment

dieknolle3333 Jul 31, 2023

Choose a reason for hiding this comment

dieknolle3333 Jul 31, 2023

Choose a reason for hiding this comment

dieknolle3333 Jul 31, 2023 • edited Loading

Choose a reason for hiding this comment

philippotto left a comment

Choose a reason for hiding this comment

philippotto left a comment

Choose a reason for hiding this comment

dieknolle3333 commented Jul 31, 2023 •

edited

Loading

dieknolle3333 Jul 31, 2023 •

edited

Loading