Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make antd messages click-through #7239

Merged
merged 4 commits into from
Jul 28, 2023
Merged

Make antd messages click-through #7239

merged 4 commits into from
Jul 28, 2023

Conversation

fm3
Copy link
Member

@fm3 fm3 commented Jul 27, 2023

Makes antd messages click-through. (A user noted that they block selecting tools during annotating, which can be annoying).

Do you think there are cases where the user wants to interact with antd messages (e.g. copy the text)? Nothing comes to my mind.

URL of deployed dev instance (used for testing):

Steps to test:

  • Brush some in a volume annotation, hit undo, try to switch tool behind the “finished undo” message
  • Should be able to click right through the message, selecting tools.

@fm3 fm3 marked this pull request as ready for review July 27, 2023 15:09
@fm3 fm3 requested a review from daniel-wer July 27, 2023 15:10
@fm3 fm3 changed the title make antd messages click-through Make antd messages click-through Jul 27, 2023
@daniel-wer daniel-wer requested review from philippotto and removed request for daniel-wer July 28, 2023 08:41
Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. ideally, messages shouldn't hide important parts of the UI, I'd argue. but it seems edge-case-y enough to go with this simple solution.

Additionally, we could try to position the message a bit "lower". According to the docs, it should be possible with this:

import { message } from 'antd';

message.config({top: 100})

Do you want to give this a try? It only needs to be executed once and should affect all future messages. I can also try this out if you want.

Do you think there are cases where the user wants to interact with antd messages (e.g. copy the text)? Nothing comes to my mind.

👍

@fm3
Copy link
Member Author

fm3 commented Jul 28, 2023

Do we have a central spot for stuff that should be executed once on pageload? the router?

@philippotto
Copy link
Member

I think, here could be an okay spot for that:

@fm3
Copy link
Member Author

fm3 commented Jul 28, 2023

Yes, that works :) Went for 30, 100 looked a bit lost on the page

@philippotto
Copy link
Member

Sweet! yes, 100 was only an example value.

@fm3 fm3 merged commit 2441ca6 into master Jul 28, 2023
@fm3 fm3 deleted the messages-click-through branch July 28, 2023 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants