-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make antd messages click-through #7239
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. ideally, messages shouldn't hide important parts of the UI, I'd argue. but it seems edge-case-y enough to go with this simple solution.
Additionally, we could try to position the message a bit "lower". According to the docs, it should be possible with this:
import { message } from 'antd';
message.config({top: 100})
Do you want to give this a try? It only needs to be executed once and should affect all future messages. I can also try this out if you want.
Do you think there are cases where the user wants to interact with antd messages (e.g. copy the text)? Nothing comes to my mind.
👍
Do we have a central spot for stuff that should be executed once on pageload? the router? |
I think, here could be an okay spot for that: webknossos/frontend/javascripts/main.tsx Line 90 in 65f15f4
|
Yes, that works :) Went for 30, 100 looked a bit lost on the page |
Sweet! yes, 100 was only an example value. |
Makes antd messages click-through. (A user noted that they block selecting tools during annotating, which can be annoying).
Do you think there are cases where the user wants to interact with antd messages (e.g. copy the text)? Nothing comes to my mind.
URL of deployed dev instance (used for testing):
Steps to test: