Skip to content

Catch exceptions in FileSystemDataVault, return Empty or Failure #7216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 24, 2023
Merged

Catch exceptions in FileSystemDataVault, return Empty or Failure #7216

merged 2 commits into from
Jul 24, 2023

Conversation

fm3
Copy link
Member

@fm3 fm3 commented Jul 19, 2023

Steps to test:

  • (I tested this already locally)
  • in local zarr dataset, delete a chunk
  • see that no exceptions are logged, and the fill value is displayed in the frontend
  • when read permissions are revoked, rate-limited logging should show, but no bare exceptions

Issues:

  • Updated changelog
  • Needs datastore update after deployment

@fm3 fm3 self-assigned this Jul 19, 2023
@fm3 fm3 requested a review from frcroth July 19, 2023 08:55
@fm3 fm3 enabled auto-merge (squash) July 24, 2023 09:55
@fm3 fm3 merged commit 24b1101 into master Jul 24, 2023
@fm3 fm3 deleted the file-system-data-vault-fox branch July 24, 2023 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frcroth frcroth frcroth approved these changes

Assignees

@fm3 fm3

Labels
backend bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FileNotFoundException in FileSystemDataVault is not caught
2 participants
@fm3 @frcroth