Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement search for segments and groups #7175

Merged
merged 5 commits into from
Jul 3, 2023
Merged

Conversation

philippotto
Copy link
Member

@philippotto philippotto commented Jun 23, 2023

Implement search for segments and groups in the segments tab (similar to the skeleton tab).

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • open an annotation
  • create many segments (e.g., by clicking on various segments on an existing segmentation layer)
  • name some segments
  • use the new search button to search for segments and use the jump feature

Issues:


Copy link
Contributor

@MichaelBuessemeyer MichaelBuessemeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works very very nicely.

I like the idea of extending the type of the searchKey for the search popover.
I just added one suggestion that you may apply or ignore.

Additional thanks for getting rid of the ts error 🚀

@MichaelBuessemeyer MichaelBuessemeyer enabled auto-merge (squash) July 3, 2023 13:43
@MichaelBuessemeyer MichaelBuessemeyer merged commit 91455a6 into master Jul 3, 2023
@MichaelBuessemeyer MichaelBuessemeyer deleted the segment-search branch July 3, 2023 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search in segment list
2 participants