Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dont show placeholders in dashboard during loading #7166

Merged
merged 2 commits into from
Jun 22, 2023
Merged

Dont show placeholders in dashboard during loading #7166

merged 2 commits into from
Jun 22, 2023

Conversation

philippotto
Copy link
Member

I noticed that the placeholders are briefly visible during loading.

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • clear localstorage, reload and ensure that placeholders are not visible during loading

Issues:

@philippotto philippotto self-assigned this Jun 21, 2023
hotzenklotz
hotzenklotz approved these changes Jun 22, 2023
View reviewed changes
Copy link
Member

@hotzenklotz hotzenklotz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@philippotto philippotto enabled auto-merge (squash) June 22, 2023 08:54
@philippotto philippotto merged commit 16e0bbf into master Jun 22, 2023
@philippotto philippotto deleted the fix-flickering-placeholder branch June 22, 2023 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hotzenklotz hotzenklotz hotzenklotz approved these changes

Assignees

@philippotto philippotto

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@philippotto @hotzenklotz