-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add table showing artifacts disk space consumption to workflow view #7152
Conversation
I'd say this pr is ready for the first review (despite the open TODO). |
I honestly don't know who should review these changes. @philippotto in case you want/know someone else that could review the changes better, please reassign the review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! only the see my one comment :)
artifactSize: formatCountToDataAmountUnit(artifact.fileSize), | ||
fileSize: artifact.fileSize, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isn't this the same? the first entry is formatted and the second is not?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right: one is the formatted value and one is the unformatted raw value.
The unformatted raw value is used to be able to sort the artifact entries properly by their size.
The formatted value is simply the value that is displayed in the table.
I looked at the docs that list the render
prop for the columns prop of a table. I updated the artifact entries to only have the file size and to format them in the render function.
This way is much better as the filesize is not contained in every entry twice. 👍
Thanks for mentioning this 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great 👍 did you push this already?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I got interrupted a little. It is pushed now :)
@philippotto Do you think I should test the artifact size table with meta tasks? If yes, I somehow need a way to get a workflow with a meta task into webknossos. |
If it's too tedious to do the testing locally, I'm also fine with merging the PR and then directly having a look in production, since the chances are rather good that it just works ™️ :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Ok, let's just |
This PR adds a new table to the vx workflow view that enables users to identify the artifacts consuming the most disk space. The table is wrapped in a modal and can be shown by clicking the "Show Disk Usage of Artifacts" option in workflow view under the menu next to the "Collapse all button" in the header on the right side of the view.
URL of deployed dev instance (used for testing):
Steps to test:
WK_URL=http://localhost:9000 WK_TOKEN=secretSampleUserToken vx voxelytics/connect/test/configs/segem_test_2d.yaml --cpu
in the working directory of vx and wait for the command to finishhttp://localhost:9000/workflows
and open the workflow.Issues:
(Please delete unneeded items, merge only when none are left open)