Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reverse compression on sharded neuroglancer datasets #7135

Merged
merged 2 commits into from
Jun 13, 2023
Merged

Reverse compression on sharded neuroglancer datasets #7135

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ca9180d
Reverse compression on sharded neuroglancer datasets
frcroth Jun 12, 2023
f72366b
Update changelog
frcroth Jun 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.unreleased.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ For upgrade instructions, please check the [migration guide](MIGRATIONS.released
- Fixed problems which could arise when annotating volume data at negative positions (which is not supported and is properly ignored now). [#7124](https://github.com/scalableminds/webknossos/pull/7124)
- Fixed some requests failing for streaming remote data via HTTP, which was observed when streaming data via Zarr from another WEBKNOSSOS instance. [#7125](https://github.com/scalableminds/webknossos/pull/7125)
- Fixed that the brush preview was inaccurate in some scenarios. [#7129](https://github.com/scalableminds/webknossos/pull/7129)
- Fixed order of decompression on neuroglancer precomputed datasets, which caused some segmentation layers to not load correctly. [#7135](https://github.com/scalableminds/webknossos/pull/7135/)

### Removed
- Support for [webknososs-connect](https://github.com/scalableminds/webknossos-connect) data store servers has been removed. Use the "Add Remote Dataset" functionality instead. [#7031](https://github.com/scalableminds/webknossos/pull/7031)
Expand Down
4 changes: 2 additions & 2 deletions ...ableminds/webknossos/datastore/datareaders/precomputed/PrecomputedCompressorFactory.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,9 @@ object PrecomputedCompressorFactory {
getCompressorForShardingChunks(shardingSpecification.data_encoding)
case None => nullCompressor
}
val outerCompression = getCompressorForEncoding(header)
val chunkCompression = getCompressorForEncoding(header)

new ChainedCompressor(Seq(shardingCompression, outerCompression))
new ChainedCompressor(Seq(chunkCompression, shardingCompression))

}

Expand Down